CleverRaven / CleverRaven/Cataclysm-DDA

Allow to craft some items with filthy parts

Open
#49,458 0 comments 3 reactions 0 assignees View on GitHub
<Bug> <Suggestion / Discussion> Crafting / Construction / Recipes
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

# Is your feature request related to a problem? Please describe.
Craft system refuses any filthy item, so filthy rags/felt/lether patches/fur pelts are not allow to be an ingredient.
However some item like Molotov and weapon are supposed to be OK with a filthy part, as it is prone to be filthy again or burnt soon.
And they're not worn on a body, there's no risk of being infected or bad morale.

# Describe the solution you'd like
Introducing a flag check `ALLOW_FILTHY`, like `lamp_oil` did(#29770). To Allow it being crafted with filthy item.

# Describe alternatives you've considered
Also considering remove `rag_bloody` item, as it was a remnant before filthy system introducing.

# Additional context

Contributor guide

Open the contributing guide

Research direction

Review the existing lamp_oil ALLOW_FILTHY implementation referenced by #29770 and identify the crafting definitions for filthy rags, felt, leather patches, and fur pelts. Confirm which Molotov and weapon recipes should accept them, then verify the affected crafting behavior and decide separately whether rag_bloody is still needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.