CleverRaven / CleverRaven/Cataclysm-DDA
Weariness indicator is useless for actions that take >1 turn
- Dominant language
- C++
- Stars
- 13.1k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
# Describe the bug
Sidebar weariness indicator, which is supposed to show info about weariness, is showing it regarding your current status instead of last action you take. For actions taking less than a (or maybe exactly one) turn, it is correctly showing activity level, weariness malus and so on. For actions that take more, it is showing `none` AL, and +0% malus.
# Steps To Reproduce
1. Make a player with slow 2h weapon
2. Achieve at least 1st tier of weariness
3. Try fighting zombies, see activity level staying at none but time flying by
It is actually flicking through 'extreme' but good luck noticing it if you don't know WTF is happening. See here https://www.twitch.tv/videos/1056295433 from about 2:28:30.
# Expected behavior
It should show AL of *character's last action* instead of showing... whatever it is. I guess because you've spent too many points previously, you arrive to current turn without technically performing an action at the beginning of it, so it counts as no activity? Or something?
# Versions and configuration
OS: Windows 7x64
Game Version: a76f7e8 [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [
Dark Days Ahead [dda]
]
Contributor guide
Research direction
Start with the sidebar weariness indicator while reproducing the issue using a slow 2h weapon and a character at the first weariness tier. Trace how the indicator handles actions lasting more than one turn, then verify that fighting zombies displays the character's last action activity level and weariness malus rather than none and +0%.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100