CleverRaven / CleverRaven/Cataclysm-DDA

Failed Tests around NPC dialogue trees

Open
#49,152 11 comments 1 reaction 0 assignees View on GitHub
[JSON] [Python] <Bug> Code: Tests NPC / Factions
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

# Describe the bug
There are a ton of fails in the CI tests around NPC dialogue. I'm making a list of them here for people to check off as they fix them.

# Steps To Reproduce
[] talk topic TALK_SHELTER referenced in an NPC chat but not defined
[] talk topic TALK_STRANGER_AGGRESSIVE referenced in an NPC chat but not defined
[] talk topic TALK_MISSION_LIST referenced in a response but not defined
[] talk topic TALK_STRANGER_NEUTRAL referenced in an NPC chat but not defined
[] talk topic TALK_LEADER referenced in an NPC chat but not defined
[] talk topic MISSION_PYROMANIAC defined but not referenced in a response
[] talk topic TALK_lighthouse_man_family defined but not referenced in a response
[] talk topic TALK_SHOUT referenced in a response but not defined
[] talk topic TALK_COMBAT_COMMANDS referenced in a response but not defined
[] talk topic TALK_TRAIN_START referenced in a response but not defined
[] talk topic TALK_OPINION referenced in a response but not defined
[] talk topic TALK_DELIVER_ASK referenced in a response but not defined
[] talk topic TALK_MISSION_DESCRIBE_URGENT referenced in an NPC chat but not defined
[] talk topic TALK_REFUGEE_Dana_Background_baking_nobarter defined but not referenced in a response
[] talk topic TALK_pizzaiolo_following defined but not referenced in a response
[] talk topic TALK_REFUGEE_Dana_1_firstmeet defined but not referenced in a response
[] talk topic TALK_MISSION_INQUIRE referenced in a response but not defined
[] talk topic TALK_STRANGER_FRIENDLY referenced in an NPC chat but not defined
[] talk topic TALK_REFUGEE_GENERAL_Refuse_Boris_Mission_1 referenced in a response but not defined
[] talk topic TALK_MISSION_OFFER referenced in a response but not defined
[] talk topic TALK_HOW_MUCH_FURTHER defined but not referenced in a response
[] talk topic TALK_WAKE_UP referenced in an NPC chat but not defined
[] talk topic TALK_FRIEND_CONVERSATION defined but not referenced in a response
[] talk topic TALK_SIZE_UP referenced in a response but not defined
[] talk topic TALK_MUG referenced in an NPC chat but not defined
[] talk topic TALK_LOOK_AT referenced in a response but not defined
[] talk topic TALK_MISSION_LIST_ASSIGNED referenced in a response but not defined
[] talk topic TALK_MISSION_DESCRIBE referenced in a response but not defined
[] talk topic TALK_REFUGEE_Boris_Son_Tough referenced in a response but not defined
[] talk topic TALK_lighthouse_man_cleaning defined but not referenced in a response
[] talk topic TALK_STOLE_ITEM referenced in an NPC chat but not defined
[] talk topic TALK_ENG_LIGHTHOUSE_WORKING defined but not referenced in a response
[] talk topic TALK_MISSION_SUCCESS referenced in a response but not defined
[] no path from a start topic to CWH_FEMA_EVACUEE_1_IDEAS1
[] no path from a start topic to BGSS_OUT_OF_TOWN_1_STORY2
[] no path from a start topic to BGSS_COP_1_STORY1
[] no path from a start topic to BGSS_SCIENTIST_2_STORY1
[] no path from a start topic to BGSS_HOSPITAL_1_STORY4
[] no path from a start topic to BGSS_OUT_OF_TOWN_2_STORY4
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_STORY4
[] no path from a start topic to BGSS_RURAL_1_STORY3
[] no path from a start topic to CWH_LEFT_FOR_DEAD_2_IDEAS1
[] no path from a start topic to BGSS_DREAMER_STORY3a
[] no path from a start topic to BGSS_CODGER_STORY3a
[] no path from a start topic to BGSS_HOSPITAL_2_STORY1
[] no path from a start topic to BGSS_PRISONER_1_STORY4
[] no path from a start topic to BGSS_EVACUEE_5_WASPS
[] no path from a start topic to CWH_LEFT_FOR_DEAD_1_IDEAS2
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_2_STORY2
[] no path from a start topic to BGSS_HOSPITAL_3_STORY2
[] no path from a start topic to BGSS_LOST_PARTNER_2_STORY3
[] no path from a start topic to BGSS_FEMA_EVACUEE_1_STORY1
[] no path from a start topic to BGSS_NO_PAST_4_STORY2
[] no path from a start topic to BGSS_NO_PAST_3_STORY3
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_3_STORY5
[] no path from a start topic to CWH_DREAMER_IDEAS2
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_OTHER
[] no path from a start topic to BGSS_GUNG_HO_3_STORY2
[] no path from a start topic to BGSS_DREAMER_STORY6
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_FUCKOFF
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_2_STORY3
[] no path from a start topic to CWH_EVACUEE_5_IDEAS1
[] TALK_GODCO_cook_ask_food_family does not reach TALK_DONE
[] no path from a start topic to BGSS_HOSPITAL_3_STORY1
[] no path from a start topic to BGSS_SOLDIER_1_STORY1
[] no path from a start topic to CWH_LEFT_FOR_DEAD_2_IDEAS2
[] TALK_GODCO_cook_1 does not reach TALK_DONE
[] no path from a start topic to CWH_NO_PAST_1_IDEAS2
[] no path from a start topic to BGSS_HIGH_SCHOOL_1_STORY1
[] no path from a start topic to TALK_REFUGEE_Dana_Recruit
[] no path from a start topic to TALK_lighthouse_man_family
[] no path from a start topic to TALK_REFUGEE_Dana_Tacoma
[] no path from a start topic to BGSS_DREAMER_STORY2
[] no path from a start topic to CWH_RELIGIOUS_1_IDEAS2
[] no path from a start topic to BGSS_HUNTER_2_STORY4
[] no path from a start topic to BGSS_LOST_PARTNER_1_STORY1
[] no path from a start topic to BGSS_HOSPITAL_2_STORY4
[] no path from a start topic to BGSS_CRIMINAL_2_STORY1
[] no path from a start topic to BGSS_PRISONER_1_STORY3
[] no path from a start topic to BGSS_HOSPITAL_2_ROOF
[] no path from a start topic to CWH_CONFUSED_1_IDEAS2
[] no path from a start topic to BGSS_CODGER_STORY1
[] no path from a start topic to BGSS_WEDDING_1_STORY1
[] TALK_GODCO_cook_ask_past does not reach TALK_DONE
[] no path from a start topic to BGSS_CODGER_STORY4a
[] no path from a start topic to BGSS_EVACUEE_1_STORY2
[] no path from a start topic to TALK_pizzaiolo_celebrate1
[] no path from a start topic to BGSS_PREPPER_1_STORY1
[] no path from a start topic to BGSS_DREAMER_STORY1
[] no path from a start topic to BGSS_EVACUEE_3_STORY3_EARLY
[] no path from a start topic to BGSS_FEMA_EVACUEE_1_NOTYET
[] TALK_GODCO_cook_ask_goods does not reach TALK_DONE
[] no path from a start topic to BGSS_HIGH_SCHOOL_1_STORY3
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_FREE_MERCHANTS
[] TALK_GODCO_cook_ask_food_bribe does not reach TALK_DONE
[] no path from a start topic to BGSS_CRIMINAL_1_STORY3
[] no path from a start topic to BGSS_GUNG_HO_1_STORY2
[] no path from a start topic to BGSS_LOST_PARTNER_2_STORY2
[] no path from a start topic to BGSS_HUNTER_1_STORY1
[] TALK_GODCO_cook_ask_mood does not reach TALK_DONE
[] no path from a start topic to BGSS_NERD_1_STORY3
[] no path from a start topic to BGSS_PRISONER_1_STORY6
[] no path from a start topic to BGSS_RURAL_2_STORY2
[] no path from a start topic to BGSS_NO_PAST_3_STORY2
[] no path from a start topic to CWH_EVACUEE_2_IDEAS1
[] no path from a start topic to BGSS_RELIGIOUS_1_STORY2
[] no path from a start topic to BGSS_CRIMINAL_2_NECROMANCER
[] no path from a start topic to BGSS_EVACUEE_3_STORY4
[] no path from a start topic to TALK_lighthouse_man_lighthouse
[] no path from a start topic to BGSS_PREPPER_2_NOSALE
[] no path from a start topic to BGSS_LOST_PARTNER_2_SOMESHIT
[] TALK_GODCO_cook_ask_food does not reach TALK_DONE
[] no path from a start topic to BGSS_EVACUEE_2_NOTYET
[] no path from a start topic to CWH_WEDDING_1_IDEAS1
[] no path from a start topic to TALK_REFUGEE_Dana_Background_baking_nobarter
[] no path from a start topic to BGSS_DREAMER_STORY3b
[] no path from a start topic to TALK_REFUGEE_Dana_Background_sorry
[] no path from a start topic to BGSS_PREPPER_2_MAPS
[] no path from a start topic to BGSS_LOST_PARTNER_2_HOME1
[] no path from a start topic to BGSS_COP_1_STORY2
[] no path from a start topic to BGSS_RURAL_1_STORY1
[] no path from a start topic to BGSS_PREPPER_1_LMOE
[] no path from a start topic to BGSS_LAB_1_STORY1
[] no path from a start topic to BGSS_WEDDING_1_STORY2
[] no path from a start topic to BGSS_GUNG_HO_3_STORY1
[] no path from a start topic to BGSS_SOLDIER_2_STORY2
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_STORY2_BADGERME
[] no path from a start topic to BGSS_EVACUEE_5_BEES
[] no path from a start topic to BGSS_PROFESSOR_1_STORY1
[] no path from a start topic to BGSS_NO_PAST_4_STORY1
[] no path from a start topic to BGSS_PREPPER_2_STORY2
[] no path from a start topic to BGSS_EVACUEE_1_STORY3
[] no path from a start topic to BGSS_COP_3_STORY1
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_METH
[] no path from a start topic to BGSS_PROFESSOR_1_SCIENCEHELP
[] TALK_GODCO_cook_ask_membership does not reach TALK_DONE
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_NUCLEAR
[] no path from a start topic to BGSS_GRAD_STUDENT_1_STORY2
[] no path from a start topic to BGSS_GUNG_HO_3_SON1
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_TAXEVASION
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_GROWOP
[] no path from a start topic to BGSS_LOST_PARTNER_2_STORY1
[] no path from a start topic to TALK_REFUGEE_Dana_2
[] TALK_LIGHTHOUSE_SURVIVOR1 does not reach TALK_DONE
[] no path from a start topic to BGSS_CODGER_STORY5
[] no path from a start topic to BGSS_PRISONER_1_STORY5
[] no path from a start topic to BGSS_EVACUEE_3_STORY3_LATE
[] no path from a start topic to BGSS_NERD_1_STORY2
[] no path from a start topic to BGSS_PREPPER_2_STORY3
[] no path from a start topic to CWH_NO_PAST_4_IDEAS1
[] no path from a start topic to CWH_LEFT_FOR_DEAD_1_EXPLAIN
[] no path from a start topic to TALK_pizzaiolo_following
[] no path from a start topic to TALK_REFUGEE_Dana_1_firstmeet
[] no path from a start topic to BGSS_SOLDIER_2_STORY1
[] no path from a start topic to BGSS_PRISONER_1_STORY1
[] no path from a start topic to CWH_RELIGIOUS_1_IDEAS1
[] no path from a start topic to CWH_CONFUSED_1_IDEAS1
[] TALK_GODCO_cook_currency does not reach TALK_DONE
[] no path from a start topic to TALK_REFUGEE_Dana_Background_baking
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_STORY2_OKAY
[] no path from a start topic to BGSS_CODGER_STORY6
[] no path from a start topic to BGSS_CRIMINAL_1_STORY2
[] no path from a start topic to BGSS_NO_PAST_5_STORY1
[] no path from a start topic to BGSS_FEMA_EVACUEE_1_STORY2
[] no path from a start topic to BGSS_EVACUEE_6_STORY1
[] no path from a start topic to BGSS_OUT_OF_TOWN_1_STORY1
[] no path from a start topic to BGSS_CODGER_STORY2
[] no path from a start topic to BGSS_LOST_PARTNER_2_NOTYET
[] no path from a start topic to BGSS_OUT_OF_TOWN_2_STORY1
[] no path from a start topic to BGSS_LOST_PARTNER_1_TRIFFIDS
[] no path from a start topic to TALK_lighthouse_man_cleaned
[] no path from a start topic to BGSS_NERD_1_PARENTS
[] no path from a start topic to CWH_EVACUEE_5_IDEAS2
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_ASSAULT
[] no path from a start topic to BGSS_SCIENTIST_1_STORY3
[] no path from a start topic to BGSS_HOSPITAL_1_STORY1
[] no path from a start topic to TALK_REFUGEE_Dana_Tacoma2
[] no path from a start topic to BGSS_RELIGIOUS_2_STORY1
[] no path from a start topic to BGSS_EVACUEE_3_STORY1
[] no path from a start topic to BGSS_OUT_OF_TOWN_2_STORY5
[] TALK_TRAIN does not reach TALK_DONE
[] no path from a start topic to BGSS_PRISONER_1_STORY2
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_STORY1
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_3_STORY1
[] no path from a start topic to BGSS_HOSPITAL_1_STORY2
[] TALK_GODCO_cook_place does not reach TALK_DONE
[] no path from a start topic to BGSS_BURGER_FLIPPER_1_STORY1
[] no path from a start topic to BGSS_EVACUEE_3_STORY2
[] no path from a start topic to TALK_lighthouse_man_fail
[] no path from a start topic to MISSION_PYROMANIAC
[] no path from a start topic to BGSS_CYBORG_1_STORY1
[] no path from a start topic to TALK_lighthouse_man_cleaned_done
[] no path from a start topic to TALK_HOW_MUCH_FURTHER
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_NICETRY
[] no path from a start topic to BGSS_PREPPER_2_STORY1
[] no path from a start topic to BGSS_SCIENTIST_1_SCIENCEHELP
[] no path from a start topic to CWH_NO_PAST_1_IDEAS1
[] no path from a start topic to BGSS_LAB_1_DIONNE1
[] no path from a start topic to BGSS_RURAL_2_STORY3
[] no path from a start topic to BGSS_EVACUEE_2_STORY2
[] no path from a start topic to BGSS_HOSPITAL_1_STORY3
[] no path from a start topic to BGSS_HOSPITAL_2_STORY2
[] no path from a start topic to BGSS_BURGER_FLIPPER_1_STORY2
[] no path from a start topic to CWH_NO_PAST_2_IDEAS1
[] no path from a start topic to BGSS_NO_PAST_3_CRAZY
[] no path from a start topic to BGSS_LAB_1_STORY3
[] no path from a start topic to CWH_LEFT_FOR_DEAD_3_IDEAS1
[] no path from a start topic to TALK_FRIEND_CONVERSATION
[] no path from a start topic to BGSS_RELIGIOUS_1_FAITH1
[] no path from a start topic to BGSS_COP_2_STORY1
[] no path from a start topic to BGSS_LOST_PARTNER_2_HOME2
[] no path from a start topic to CWH_NO_PAST_4_IDEAS2
[] no path from a start topic to BGSS_SCIENTIST_1_STORY2
[] no path from a start topic to BGSS_EVACUEE_1_STORY1
[] no path from a start topic to BGSS_SCIENTIST_1_STORY1
[] no path from a start topic to BGSS_CODGER_STORY3b
[] no path from a start topic to TALK_REFUGEE_Dana_Background
[] no path from a start topic to BGSS_EVACUEE_4_STORY1
[] no path from a start topic to BGSS_HOSPITAL_2_STORY3
[] no path from a start topic to CWH_EVACUEE_3_IDEAS1
[] no path from a start topic to BGSS_SCIENTIST_2_SCIENCEHELP
[] no path from a start topic to BGSS_LAB_1_STORY2
[] no path from a start topic to CWH_NO_PAST_4_SKEPTIC
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_3_STORY2
[] no path from a start topic to BGSS_PREPPER_1_STORY2
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_2_STORY1
[] no path from a start topic to CWH_FEMA_EVACUEE_1_IDEAS3
[] no path from a start topic to BGSS_PREPPER_2_SOLD
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_STORY3
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_3_STORY4
[] no path from a start topic to CWH_EVACUEE_1_IDEAS1
[] no path from a start topic to BGSS_HOSPITAL_3_STORY3
[] no path from a start topic to CWH_LEFT_FOR_DEAD_3_IDEAS2
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_3_STORY3
[] no path from a start topic to BGSS_pizzaiolo_STORY2
[] no path from a start topic to BGSS_BURGER_FLIPPER_1_STORY3
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_STORY2
[] no path from a start topic to BGSS_SCAVENGER_MERC_1_OLD_GUARD
[] no path from a start topic to BGSS_COP_3_STORY2
[] no path from a start topic to BGSS_LOST_PARTNER_2_FUCKOFF
[] no path from a start topic to BGSS_RELIGIOUS_1_STORY1
[] no path from a start topic to BGSS_HUNTER_2_STORY1
[] no path from a start topic to BGSS_COP_3_STORY3
[] no path from a start topic to BGSS_GUNG_HO_1_STORY1
[] TALK_GODCO_cook_firstmeet does not reach TALK_DONE
[] no path from a start topic to CWH_EVACUEE_6_IDEAS1
[] no path from a start topic to BGSS_pizzaiolo_STORY1
[] no path from a start topic to BGSS_HUNTER_2_STORY3
[] no path from a start topic to BGSS_CONFUSED_1_STORY1
[] no path from a start topic to BGSS_WEDDING_1_STORY3
[] no path from a start topic to CWH_DREAMER_IDEAS1
[] no path from a start topic to BGSS_DREAMER_STORY5
[] no path from a start topic to CWH_EVACUEE_3_IDEAS2
[] no path from a start topic to BGSS_PREPPER_1_STORY3
[] no path from a start topic to BGSS_HUNTER_2_STORY2
[] no path from a start topic to BGSS_COP_2_STORY2
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_BIOWEAPON
[] no path from a start topic to BGSS_LOST_PARTNER_1_NOWAY
[] no path from a start topic to CWH_FEMA_EVACUEE_1_IDEAS2
[] no path from a start topic to BGSS_NO_PAST_2_STORY1
[] no path from a start topic to TALK_REFUGEE_Dana_Background_baking2
[] no path from a start topic to BGSS_LOST_PARTNER_1_STORY2
[] no path from a start topic to BGSS_OUT_OF_TOWN_2_STORY2
[] no path from a start topic to BGSS_HOSPITAL_2_NOTYET
[] no path from a start topic to CWH_RELIGIOUS_2_IDEAS1
[] no path from a start topic to BGSS_NERD_1_STORY1
[] no path from a start topic to BGSS_NO_PAST_3_STORY1
[] no path from a start topic to BGSS_LOST_PARTNER_1_YEAH
[] no path from a start topic to BGSS_FEMA_EVACUEE_1_STORY3
[] no path from a start topic to BGSS_PRISONER_1_IN_FOR_ORGANS
[] no path from a start topic to BGSS_EVACUEE_2_STORY1
[] no path from a start topic to BGSS_GRAD_STUDENT_1_FIELD
[] no path from a start topic to CWH_LEFT_FOR_DEAD_1_IDEAS1
[] no path from a start topic to BGSS_CRIMINAL_1_PAROLE
[] no path from a start topic to BGSS_LEFT_FOR_DEAD_1_STORY1
[] no path from a start topic to TALK_REFUGEE_Dana_Background_baking2_yesbarter
[] no path from a start topic to BGSS_GUNG_HO_2_STORY1
[] no path from a start topic to BGSS_CODGER_STORY4b
[] no path from a start topic to BGSS_GUNG_HO_3_FEMA1
[] no path from a start topic to BGSS_CRIMINAL_2_STORY3
[] no path from a start topic to BGSS_DREAMER_STORY4
[] no path from a start topic to BGSS_GUNG_HO_1_STORY3
[] no path from a start topic to BGSS_HUNTER_1_STORY2
[] no path from a start topic to BGSS_OUT_OF_TOWN_1_STORY3
[] no path from a start topic to BGSS_RELIGIOUS_1_FAITH2
[] no path from a start topic to BGSS_WEDDING_1_CALM
[] no path from a start topic to BGSS_EVACUEE_5_STORY1
[] no path from a start topic to BGSS_EVACUEE_1_STORY4
[] no path from a start topic to CWH_EVACUEE_4_IDEAS1
[] no path from a start topic to TALK_lighthouse_man_cleaning
[] no path from a start topic to BGSS_HIGH_SCHOOL_1_STORY2
[] no path from a start topic to BGSS_RURAL_1_STORY2
[] no path from a start topic to BGSS_RURAL_2_STORY1
[] no path from a start topic to BGSS_EVACUEE_4_STORY2
[] TALK_REFUGEE_JENNY_Teach2 does not reach TALK_DONE
[] no path from a start topic to BGSS_NO_PAST_1_STORY1
[] no path from a start topic to BGSS_EVACUEE_4_STORY3
[] no path from a start topic to TALK_pizzaiolo_celebrate
[] no path from a start topic to BGSS_NO_PAST_4_DROPIT
[] no path from a start topic to TALK_REFUGEE_Dana_Background_baking_revival
[] no path from a start topic to TALK_ENG_LIGHTHOUSE_WORKING
[] no path from a start topic to BGSS_CRIMINAL_2_STORY2
[] TALK_LIGHTHOUSE_SURVIVOR does not reach TALK_DONE
[] no path from a start topic to TALK_REFUGEE_Dana_Background_baking2_nobarter
[] no path from a start topic to BGSS_OUT_OF_TOWN_2_STORY3
[] no path from a start topic to BGSS_CRIMINAL_1_STORY1
[] no path from a start topic to BGSS_GRAD_STUDENT_1_STORY1
[] no path from a start topic to BGSS_GRAD_STUDENT_1_STORY3
[] no path from a start topic to BGSS_FEMA_EVACUEE_1_ESCAPE1
[] no path from a start topic to TALK_REFUGEE_Dana_Situation

# Expected behavior
These tests should pass.

# Screenshots

# Versions and configuration

# Additional context

Contributor guide

Open the contributing guide

Research direction

Start by running the CI tests that report the NPC dialogue-tree failures and inspect the corresponding dialogue definitions and responses. Work through the listed missing references and unreachable topics; done means the relevant CI dialogue checks pass without those failures.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.