CleverRaven / CleverRaven/Cataclysm-DDA

Fish trap doesn't work well outside of reality bubble

Open
#48,485 6 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) <Bug> Items / Item Actions / Item Qualities Map / Mapgen Spawn
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

Fish trap doesn't work well outside of reality bubble.

# Steps To Reproduce

1. Make a player with survival 6, select 'river' start or find river.
2. Spawn fish trap & bait, wristwatch, find riverbank with fish visible.
3. Place loaded fish trap, set alarm for 3h
4. Move away from trap 60+ tiles to leave it outside of RB
5. Wait for 3h
6. Return, check result: no fish caught
7. Repeat test 5-10 times: almost no fish caught at all (1-2 on 10 attempts).
8. Repeat the test, but stay near fish trap: at least 1 fish is caught on most attempts.

# Expected behaviour
Expected not to babysit fish trap, should produce same results (i.e. high chance to catch a fish with survival 6) regardless whether it's in or out of reality bubble

# Versions and configuration

- OS: Windows
- OS Version: 10.0 2004
- Game Version: 0.E-10377-g3860b0e [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Bionic Professions [package_bionic_professions],
Blaze Industries [blazeindustries],
C.R.I.T Expansion Mod [crt_expansion],
Craft Ammo Mags & Belt Links [SD_Magcrafting],
Mining Mod [Mining_Mod],
No Fungal Monsters [No_Fungi],
SpeedyDex [speedydex],
Stats Through Skills [StatsThroughSkills]
]

Contributor guide

Open the contributing guide

Research direction

No source file or test is named. Start by reproducing the fish-trap result with the listed steps, then trace how traps are processed inside and outside the reality bubble. Done means a loaded trap has the same catching behavior whether the player remains nearby or moves more than 60 tiles away.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.