CleverRaven / CleverRaven/Cataclysm-DDA
Fire cannot exist on a tile with any amount of spilled liquid
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 13.2k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
Description:
Setting fire to fungal tiles (and presumably other tiles?) with any amount of spilled liquid on them will not result in the fungal tile burning up. There will be a fire briefly and then it will fizzle out into smoke,
Steps To Reproduce
- Find flammable floor tiles
- Spill any amount of water onto flammable tile
- Set fire directly to the tile with spilled water or the flammable tiles around it
- Wait until fire burns out.
All flammable floor tiles without liquid on them will have burned away while the tile with a minute amount of spilt liquid will survive regardless of the amount of heat applied or being lit on fire or having all the tiles around it burn away.
Expected behavior
The expected behaviour in this case is I believe spilt water should form steam or burn up in some way and the floor tile should be destroyed. This should happen for obvious logical reasons but also because this bug causes the very odd problem that in order to burn away fungus in a lab or in general I need to set fire to the fungus growth and wait till it dissipates and then find a mop and mop up spilt water from broken toilets which are preventing the fungus tiles underneath toilets from burning up. Not mopping up random toilet water results in the entire infestation re-growing from the "protected" fungus tiles.
Versions and configuration
- OS: Windows
- OS Version: 10.0 2004
- Game Version: 0.E-8013-g170da18 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Bionic Professions [package_bionic_professions],
Blaze Industries [blazeindustries],
No Rail Stations [No_Rail_Stations],
Aftershock [aftershock]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Reproduce the fungal-tile scenario in the game, then trace the fire and spilled-liquid interactions; done means a flammable tile with any amount of liquid can burn away as expected, with regression coverage if the relevant test area is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100