CleverRaven / CleverRaven/Cataclysm-DDA
[Magiclysm] All spells ignore armor entirely and always target torso
- Dominant language
- C++
- Stars
- 13.1k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 200
Description
# Describe the bug
All the spells used against the player always hit the torso and not any other bodypart.
Also, whatever the damage type, worn armor doesn't seem to reduce the damage from spells (eg: Burning Hands spell from demon spiders doesn't seem to be affected by specialized anti-fire armor)
# Steps To Reproduce
1. Wear armor which protects against a specific damage type (firesuit for example)
2. Go fight a monster which has a spell ability with that type of damage (demon spider for example)
3. Get hit by the spell and check that only the torso gets hit, and the damage doesn't seem affected by the firesuit armor
# Expected behavior
Apart from very specific spells, damage should be randomly assigned to a body part and not always the torso.
AOE spells should probably split their damage on all body parts randomly.
Armor should reduce damage from spells which don't have "pure" damage type.
# Versions and configuration
Latest experimental, only Magiclysm enabled
# Additional context
I'm not sure if this is an intended behaviour or not, but it doesn't seem to be, and a quick search didn't return other issues regarding this.
Contributor guide
Research direction
Reproduce the issue with a firesuit and a demon spider using the steps in the report, then trace the spell damage and body-part handling from the relevant combat entry point. Done means spell damage can respect applicable armor and non-special-case spells no longer always hit the torso, with area damage behavior clarified and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100