CleverRaven / CleverRaven/Cataclysm-DDA

Felling trees inappropriately creates dirt squares

Open
#42,428 4 comments 1 reaction 0 assignees View on GitHub
<Bug> Fields / Furniture / Terrain / Traps Map / Mapgen
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

# Describe the bug

Logs from a felled tree create dirt squares under themselves inappropriately overwriting other types of terrain. For instance, a tree growing on top of a LMOE shelter can fall on top of stairs and other trees creating dirt squares.

# Steps To Reproduce

1. Find an LMOE shelter or other raised structure with a tree on top
2. Fell the tree so that it falls on stairs/other trees
3. Chop the resulting logs and notice that dirt squares remain

# Expected behavior

A felled tree should not change terrain under itself, especially not create walkable terrain.

# Screenshots

![Screenshot_2020-07-24_11-45-16](https://user-images.githubusercontent.com/46329185/88380163-50136380-cda4-11ea-9b42-66de863f732f.png)

# Versions and configuration

- OS: Arch Linux
- Game Version: O.E-2
- Graphics version: Tiles
- Ingame language: English
- Mods loaded: Disable NPC Needs, No Rail Stations, sees-player icon (retrodays), Bionic slots, Alternative map keys

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the LMOE shelter scenario described in the issue: fell a tree onto stairs or another tree, then chop the logs. Trace the terrain changes caused by tree falling and log removal; done means preserving the underlying terrain without leaving dirt or creating walkable squares.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.