CleverRaven / CleverRaven/Cataclysm-DDA
NPCs never have items to give when asked.
- Dominant language
- C++
- Stars
- 13.1k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
# Describe the bug
Most NPCs have the option to request they give items to help you out. Depending on your social stats and other random variables, you have a chance for them to agree to give you something. This chance increases if you are helping them out, you can use this as "leverage" or something to give a higher chance of being granted an item.
Regardless, whenever a success is achieved when asking an NPC for help with items, the message "X____NPC has nothing to give" comes up. This happens even when an NPC has items in their inventory.
When succeeding at a request to have an NPC give you an item, the message "NPC has nothing to give" ALWAYS comes up, and no items are shared. This happens regardless of success %, and regardless of what items are in the NPC's inventory.
# Steps To Reproduce
Probably the easiest way would be to do any Refugee Center start with a high-speech character. Enter dialogue with NPCs, request they share an item. It will always fail to grant an item even if the request % is a success.
Contributor guide
Research direction
No source file, test, or entry point is named. Reproduce the issue from a Refugee Center start with a high-speech character, then trace the NPC dialogue request for shared items; done means a successful request can provide an inventory item and still correctly report when none is available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100