CleverRaven / CleverRaven/Cataclysm-DDA

If clothes fit character A, they fit character B in the same world

Open
#27,293 11 comments 2 reactions 0 assignees View on GitHub
<Suggestion / Discussion> Mechanics: Character / Player stale
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

**Describe the bug**
Clothing that fits one character will fit another character if they stumble on it in the same world. This can lead to exploits such as having several characters commit suicide in a known location so that characters afterwards can get their stuff. It also implies that every survivor has the same measurements, which is weird.

**To Reproduce**
Steps to reproduce the behavior:
1. Make a character in a world that does not reset when that character dies.
2. Kill that character
3. If another one finds that character's body, the clothing will still fit if it did before.

**Expected behavior**
Clothing that fits one character may or may not fit another.

**Versions and configuration(please complete the following information):**
- OS: N/A
- Game Version: Build #8336
- Graphics version: N/A
- Mods loaded: N/A

**Additional context**
I've been thinking about this issue for a long time. The simplest solution would be to reroll clothing if a new character comes across it, but I don't know how possible that is. Another more involved solution is to give characters a size stat randomly at char gen, between, say, 1 and 5, and give all clothing a random size stat as well. Clothing would fit if the sizes were equal, and would be poor fitting otherwise. This would be more in-depth, but hits some realism problems because while you can wear clothes that are too big without breaking them, trying to do the same with clothes that are too small would cause problems.

Alternatively, we can ignore this issue. It is, admittedly, not a major concern. I typically reset my worlds when my characters die anyhow, as having a character come across an existing base causes bigger issues than "clothes shouldn't all fit just the same way". Namely the fact that they have all of that prior character's clothes, guns, cars, weapons, and whatever else they leave behind.

Contributor guide

Open the contributing guide

Research direction

No source file, test, or entry point is identified. Reproduce the clothing-fit behavior with characters sharing a persistent world, then locate the existing fit logic and decide which proposed behavior is intended. Done means the issue has a specified fitting rule and coverage for clothing transferred between characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.