CleverRaven / CleverRaven/Cataclysm-DDA

Getting attacked while receiving training from NPC loses all progress

Open
#23,596 3 comments 0 reactions 0 assignees View on GitHub
<Bug> NPC / Factions
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
1d 23h
Merged PRs (30d)
186

Description

Game version: 420b8c35b0336e627cf3186d2b6ee9d38aeb8eab

Operating system: GNU/Linux

Tiles or curses: tiles

Mods active: Default

### Expected behavior
If you receive training from an NPC, but you get attacked and choose to abort the training, the NPC lets you continue the training (under normal circumstances).

### Actual behavior
If you abort the training for any reason (i.e. you get attacked), the training is lost forever, thus you wasted your money or your reward for completing a mission.

### Steps to reproduce the behavior
* Finish a mission an NPC gave you
* Choose training as a reward
* Get attacked while training

Contributor guide

Open the contributing guide

Research direction

No source file, test, or entry point is named. Start by reproducing the NPC training flow with the Default mods on tiles, then trace what happens when an attack interrupts and training is aborted. Done means the paid or mission-earned training remains available so the NPC can resume it afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.