CleanCocoa / CleanCocoa/Omnibar

improve suggestion request/response version check

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
24
Forks
2
PR merge metrics
No merged PRs in 30d

Description

At the moment, the `RxOmnibarDelegateProxy` adds a version number to each content update generated by the user typing something in. Now client code can reference this version number to give the component a chance to discard outdated suggestions.

Something like this was necessary, but I don't like the current approach very much.

Also, the 64bit Integer could theoretically overflow at the moment.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.