CivicTechTO / CivicTechTO/missing-persons

Only grab single version of full size image url

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
9
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Re-ticketed [from Slack msg](https://civictechto.slack.com/archives/C03DJRS2ZRV/p1654059008306579)

Currently, this gets scraped:

```json
"PageImages": [
"https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2064&thumb=medium",
"https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2064&thumb=small",
"https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2065&thumb=medium",
"https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2065&thumb=small"
],
```

but this would actually return the full image:

https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2065

We should dedup and strip the `thumb` query param

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.