CivicDataLab / CivicDataLab/DataSpaceBackend
28 Django tests are stale after the chart and metadata refactors
@anantjain341 is already working on this.
Since Sep 17, 2026.
- Dominant language
- Python
- Stars
- 2
- Forks
- 1
- Avg merge
- 52m
- Merged PRs (30d)
- 40
Description
What: 28 Django tests fail on dev — tests/object_types/charts/* (23) and tests/schema/test_dataset_schema.py::TestAddUpdateDatasetMetadata (5). They were left behind by the chart consolidation and the metadata refactor.
Why it matters: they are excluded from the new Django Tests CI job, so that code has no coverage.
Evidence: BaseChart.__init__() takes 2 positional arguments but 4 were given; AttributeError: Mock object has no attribute '_state'.
Fix: not fixed — update the tests to the current signatures, then drop the --ignore/--deselect from .github/workflows/django-tests.yml. Note test_grouped_bar_chart.py also had a syntax error (duplicate options kwarg, JS true) repaired in #188; before that the whole suite failed to collect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.