CivicDataLab / CivicDataLab/CivicDataSpace-test

tests/consumer/functional/ is in no CI job path, so the registration tests never run

Open
#23 0 comments 0 reactions 1 assignee View on GitHub

@saqibmanan is already working on this.

Since Sep 9, 2026.

enhancement
Dominant language
Python
Stars
0
Forks
0
Avg merge
1h 45m
Merged PRs (30d)
56

Description

tests/consumer/functional/ is in no CI job's path. The jobs run:

  • consumer-smoketests/consumer/smoke
  • api-smoketests/api/smoke
  • provider-smoketests/provider/smoke

So the three registration tests added in #21 — including the privacy-consent enforcement check — never execute in CI. They pass locally against dev.

Worth a deliberate decision

There is a real argument for leaving it: those tests create real user accounts in the Keycloak realm. They clean up in fixture teardown and skip entirely when no admin token is available, so they are safe, but not running them on every push is a defensible default rather than an oversight.

The problem is that it currently is an oversight — the path simply was never added, and nothing records the choice.

Options:

  1. Leave as-is and document that tests/consumer/functional/ is local/manual only.
  2. Add the path to consumer-smoke, which already selects smoke or functional on workflow_call and workflow_dispatch, so the registration tests would run on deploys but not on every push.
  3. Run them on a schedule rather than per-merge.

Option 2 matches the existing marker logic most closely.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.