CircleCI-Public / CircleCI-Public/ruby-orb

Provide new option to opt out of `--seed` in `rspec-test` command

Open Beginner friendly
#179 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
25
Forks
55
PR merge metrics
No merged PRs in 30d

Description

## Describe Request:

I'd like to opt out of `--seed "$RANDOM"` (passed to `bundle exec rspec`) when using the `rspec-test` command, which was introduced in PR #174, since [v2.7.0](https://github.com/CircleCI-Public/ruby-orb/releases/tag/v2.7.0).

https://github.com/CircleCI-Public/ruby-orb/blob/9763b5737a755de7db4dc2779da1b9809ab0e0ef/src/scripts/rspec-test.sh#L55-L58

In large test suites, it's often hard to fix flaky tests (which can be exposed by `--seed`) in the short term. For example, it'd be helpful if we could gradually fix such tests with a seed-enabled branch, while the main branch disables seed (it can benefit from other changes in ruby-orb).

## Examples:

```yaml
steps:
- ruby/rspec-test:
seed: false # default: true
```

(The above is just an example. I don't have any preference for the option name or type right now.)

## Supporting Documentation Links:

N/A

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/scripts/rspec-test.sh at the linked lines 55-58 and trace how the rspec-test command passes options to bundle exec rspec. Add the requested opt-out while preserving the current default behavior, then verify that seed: false omits --seed and the default still uses it.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, shell
Domain
ci-cd, testing
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.