CircleCI-Public / CircleCI-Public/aws-cli-orb

windows install breaks if bash option `pipefail` is set

Open
#242 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
61
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

On a windows executor the aws-cli/install breaks with a SIGPIPE if the `-o pipefail` is set for bash. `-o pipefail` is considered good practice for all shellscripts and should be supported.

```yaml
orbs:
aws-cli: circleci/aws-cli@5.4.2
```

```yaml
executor:
name: win/server-2022
size: large # 8-core
shell: bash.exe -euo pipefail
```

```yaml
- aws-cli/install:
version: v2.35.11
override_installed: true
```

```text

Detected OS: Windows.
Chocolatey v2.7.2
Uninstalling the following packages:
awscli

awscli v2.34.46
Running auto uninstaller...
Auto uninstaller has successfully uninstalled awscli or detected previous uninstall.
awscli has been successfully uninstalled.
Environment Vars (like PATH) have changed. Close/reopen your shell to
see the changes (or in powershell/cmd.exe just type `refreshenv`).

Chocolatey uninstalled 1/1 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Did you know the proceeds of Pro (and some proceeds from other
licensed editions) go into bettering the community infrastructure?
Your support ensures an active community, keeps Chocolatey tip-top,
plus it nets you some awesome features!
https://chocolatey.org/compare
Installing AWS CLI v2
Chocolatey v2.7.2
Installing the following packages:
awscli
By installing, you accept licenses for the packages.
Downloading package from source 'https://community.chocolatey.org/api/v2/'
Progress: Downloading awscli 2.35.11... 100%

awscli v2.35.11 [Approved]
awscli package files install completed. Performing other installation steps.
Downloading awscli 64 bit
from 'https://awscli.amazonaws.com/AWSCLIV2-2.35.11.msi'
Progress: 100% - Completed download of C:\Users\circleci\AppData\Local\Temp\chocolatey\awscli\2.35.11\AWSCLIV2-2.35.11.msi (46.12 MB).
Download of AWSCLIV2-2.35.11.msi (46.12 MB) completed.
Hashes match.
Installing awscli...
awscli has been installed.
awscli may be able to be automatically uninstalled.
Environment Vars (like PATH) have changed. Close/reopen your shell to
see the changes (or in powershell/cmd.exe just type `refreshenv`).
The install of awscli was successful.
Software installed as 'MSI', install location is likely default.

Chocolatey installed 1/1 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Exited with code exit status 141
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the aws-cli/install command in this orb and reproduce the reported installation on a Windows executor using bash.exe -euo pipefail. Trace the command that produces exit status 141, then verify that aws-cli/install completes successfully with pipefail enabled and the requested AWS CLI version installed.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, bash, shell
Domain
cli, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.