ChromeDevTools / ChromeDevTools/debugger-protocol-viewer

Remove redirected items from search results

Open
#84 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
893
Forks
188
Avg merge
2d 23h
Merged PRs (30d)
2

Description

We are not showing methods/events that were moved to other domain in their old domain:

https://github.com/ChromeDevTools/debugger-protocol-viewer/blob/ab43fc2e604ae82d250064d597341af46f542f0f/_includes/domain.html#L14

However, in search results we have links to both: new and the old domain. Old domain links are broken. See 'highlightNode' that was moved from DOM to Overlay:

screen shot 2017-09-01 at 00 03 05

We should either:

  • show redirected items in their old domains with label "deprecated" or
  • stop generating broken links (create-search-index.js).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with create-search-index.js and the domain rendering referenced at _includes/domain.html#L14. Inspect how moved methods such as highlightNode appear in the generated search results, then compare the available approaches in the issue. Done means old-domain search links are no longer broken, either by labeling redirected items as deprecated or by removing those links.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
search, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.