ChrisTitusTech / ChrisTitusTech/website

Including styles directly into html instead of linking to cacheable file

Open
#121 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
126
Forks
58
Avg merge
2d 9h
Merged PRs (30d)
21

Description

Looks like, for some reason, your styles (bootstrap et al) are being compiled into the HTML source directly, as opposed to what should be happening where you build a minified file and link to it.

File in question:

https://github.com/ChrisTitusTech/website/blob/master/themes/northendlab/layouts/partials/style.html#L13

Outputs this type of HTML output, as opposed to a link:

<style crossorigin="anonymous" media="all" type="text/css" integrity="sha512-60QIAY7Yi6cKKh3VUI6HREzGaXrHl7UqV2j5uT96MUpy/eQCi3m9Z9Y0b/trMOTntP5AoAi0iCnOBdwAnbhpjg==">/*!* Bootstrap v4.6.0 (https://getbootstrap.com/)
--
  | * Copyright 2011-2021 The Bootstrap Authors

In its current state, you're transferring the static css every time a page loads, as opposed to allowing the single file to be cached on the browser, causing further load delay.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in themes/northendlab/layouts/partials/style.html at line 13 and inspect how the styles are included in the generated HTML. Verify the current output and determine how the compiled CSS should instead be linked as a cacheable file. Done means pages reference the static minified stylesheet rather than embedding the full CSS in each response.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap
Domain
frontend, performance
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.