Chocobozzz / Chocobozzz/PeerTube

Support disabling rates limit

Open
#6,089 4 comments 0 reactions 0 assignees View on GitHub
good first issue Type: Feature Request :sparkles:
Dominant language
TypeScript
Stars
15.3k
Forks
1.8k
Avg merge
8d 8h
Merged PRs (30d)
2

Description

### Describe the problem

This is my current rate limits configure
```yaml
rates_limit:
api:
window: 10 seconds
max: 0
login:
window: 5 minutes
max: 0
signup:
window: 5 minutes
max: 0
ask_send_email:
window: 5 minutes
max: 0
receive_client_log:
window: 10 minutes
max: 0
plugins:
window: 10 seconds
max: 0
well_known:
window: 10 seconds
max: 0
feeds:
window: 10 seconds
max: 0
activity_pub:
window: 10 seconds
max: 0
client:
window: 10 seconds
max: 0
```
When I visit the page, I received `429 Too many request` error.

If I want to set all peertube rate limits to unlimit in v6.0.1, what value should I set?

### Additional information

* PeerTube instance URL:
* PeerTube version: v6.0.1
* NodeJS version: v18.19.0
* Ffmpeg version:
* Redis version: 7.0
* PostgreSQL version: 13.3

Contributor guide

Open the contributing guide

Research direction

Start by tracing the rates_limit configuration entry point for max: 0 and reproduce the 429 behavior described for PeerTube v6.0.1. Check how the listed rate-limit groups interpret an unlimited setting, then verify that requests no longer receive 429 responses when limits are disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.