ChimeraTK / ChimeraTK/DeviceAccess
Code Cleanup: Improve FixedPointConverter
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 12
- Forks
- 12
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 13
Description
The internal structure of the FixedPointConverter should be improved into two logical steps (as done in the IEEE754_SingleConverter).
- convert the raw data to the "generic" representation in the CPU (integer or double, depending on the fixed point representation)
- convert CPU representation to the cooked type
In the IEEE754_SingleConverter a class RoundingRangeCheckingDataConverter has been introduced for this, which copies parts of the code from FixedPointConverter. This class is currently in the IEEE754_SingleConverter header and should be factored out (also into a detail namespace) so both converters can use it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate FixedPointConverter and the IEEE754_SingleConverter header, then compare their conversion paths and the RoundingRangeCheckingDataConverter implementation. Factor the shared class into a detail namespace and reorganize FixedPointConverter into raw-to-generic and generic-to-cooked steps; done means both converters can use the shared class.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100