ChimeraTK / ChimeraTK/ApplicationCore

Boost/Process components deprecated/remove in 1.88

Open
#489 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1
Forks
5
Avg merge
1m
Merged PRs (30d)
1

Description

What

The compilation fails with Boost 1.91, see error below:

ApplicationCore/Modules/src/ScriptedInitialisationHandler.cc: In member function ‘void ChimeraTK::ScriptedInitHandler::doInit()’:
ApplicationCore/Modules/src/ScriptedInitialisationHandler.cc:39:11: error: ‘ipstream’ is not a member of ‘bp’
   39 |       bp::ipstream out;
      |           ^~~~~~~~
ApplicationCore/Modules/src/ScriptedInitialisationHandler.cc:40:11: error: ‘child’ is not a member of ‘bp’
   40 |       bp::child initScript(_command, (bp::std_out & bp::std_err) > out);
      |           ^~~~~
ApplicationCore/Modules/src/ScriptedInitialisationHandler.cc:40:11: note: suggested alternatives:
In file included from /usr/include/boost/xpressive/detail/core/access.hpp:18,
                 from /usr/include/boost/xpressive/detail/core/state.hpp:18,
                 from /usr/include/boost/xpressive/detail/core/matcher/alternate_end_matcher.hpp:20,
                 from /usr/include/boost/xpressive/detail/core/matchers.hpp:17,
                 from /usr/include/boost/xpressive/regex_primitives.hpp:22,
                 from /usr/include/boost/xpressive/xpressive_static.hpp:24,
                 from /usr/include/boost/graph/graphviz.hpp:36,
                 from ApplicationCore/include/Model.h:13,
                 from ApplicationCore/include/ApplicationModule.h:7,
                 from ApplicationCore/Modules/include/ScriptedInitialisationHandler.h:5,
                 from ApplicationCore/Modules/src/ScriptedInitialisationHandler.cc:3:

Apperently there is a breaking change in boost/process 1.88, though I have not found the documentation nor any deprecation warnings prior. But I must admit that I'm not very familiar with boost.

But I did find a similar issue in SuperSlicer, which introduces some sort of compatibility code.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ApplicationCore/Modules/src/ScriptedInitialisationHandler.cc and inspect how its Boost.Process types are used. Reproduce the compilation failure with Boost 1.91, then compare the compatibility approach in the linked SuperSlicer pull request. Done means the project builds successfully with the affected Boost versions and the scripted initialisation path remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.