ChimeraTK / ChimeraTK/ApplicationCore
Improve handling of PVs with unsupported type
Open
Nobody has claimed this yet.
redmine
- Dominant language
- C++
- Stars
- 1
- Forks
- 5
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
When e.g. trying to create a ScalarPollInput<bool>, ApplicationCore fails with:
Application.cc:734: void ChimeraTK::Application::makeConnectionsForNetwork(ChimeraTK::VariableNetwork&): Assertion `callable.done' failed.
The TypedMakeConnectionCaller should check the type and raise a logic_error with appropriate message.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Application.cc:734 and trace how TypedMakeConnectionCaller handles the unsupported ScalarPollInput type during network connection setup. The change is complete when this case raises a logic_error with an appropriate message instead of reaching the callable.done assertion; check for existing connection or error-handling tests before adding coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100