ChilliCream / ChilliCream/graphql-platform
GraphQLHttpEventStreamProcessor should be able to handle heartbeats
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 5.8k
- Forks
- 810
- Avg merge
- 15h 39m
- Merged PRs (30d)
- 98
Description
Product
Hot Chocolate
Is your feature request related to a problem?
HotChocolate.Transport.Http.GraphQLHttpEventStreamProcessor should not throw an error when a message like
event: next
data: {}
is sent from the server
The solution you'd like
GraphQLHttpEventStreamProcessor should ignore those events
https://www.apollographql.com/docs/graphos/routing/operations/subscriptions/multipart-protocol#heartbeats
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at HotChocolate.Transport.Http.GraphQLHttpEventStreamProcessor and review how it handles events containing event: next with an empty data object. Use the Apollo multipart protocol heartbeat example as the expected behavior, then verify that these events are ignored without an error and that normal events remain processed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, graphql
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100