ChilliCream / ChilliCream/graphql-platform
outputDirectoryName can never be overwritten
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 5.8k
- Forks
- 810
- Avg merge
- 15h 39m
- Merged PRs (30d)
- 98
Description
Product
Hot Chocolate
Version
15.1.3
Link to minimal reproduction
https://github.com/ChilliCream/graphql-platform/discussions/8250
Steps to reproduce
It happens in every solution with this version
What is expected?
If I overwrite outputDirectoryName it will be set as I want
What is actually happening?
output file will always be set in Line 58
Relevant log output
Additional context
I don't know if this is a bug or if it's intended. I don't think it is well-made.
In "StrawberryShake.Server" Version "15.1.3" you cannot generate the files as it used to be because you cannot overwrite outputDirectoryName in the config file. Now the generated data just lands in obj directory, see code:
outputDirectoryName can never be overwritten in config file because output file will always be set in Line 58
graphql-platform/src/StrawberryShake/MetaPackages/Common/MSBuild/StrawberryShake.targets
Line 58 in ed5ac28
$(GenCommand) -o "$(GraphQLCodeGenerationRoot)"
see
graphql-platform/src/StrawberryShake/Tooling/src/dotnet-graphql/GenerateCommand.cs
Line 125 in ed5ac28
var outputDir = args.OutputDir ??
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/StrawberryShake/MetaPackages/Common/MSBuild/StrawberryShake.targets at line 58 and src/StrawberryShake/Tooling/src/dotnet-graphql/GenerateCommand.cs at line 125. Trace how outputDirectoryName and GraphQLCodeGenerationRoot are passed into generation, then verify the Strawberry Shake generation flow honors the configured output directory instead of always selecting the obj directory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100