ChilliCream / ChilliCream/graphql-platform

Generated client has wrong namespace for ComparisonHelper

Open
#5,668 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🌶️ strawberry shake
Dominant language
C#
Stars
5.8k
Forks
810
Avg merge
15h 39m
Merged PRs (30d)
98

Description

Is there an existing issue for this?
  • I have searched the existing issues
Describe the bug

When using version 13.0.0-preview.93 of StrawberryShake and generating a client from graphql scheme, the generated client has some methods that depend on "ComparisonHelper". These methods has the wrong namespace in the generated code, they refer to global::StrawberryShake.Helper.ComparisonHelper.SequenceEqual(Items, other.Items) when the correct namespace seems to be "Internal", so this seems correct: global::StrawberryShake.Internal.ComparisonHelper.SequenceEqual(Items, other.Items).

Steps to reproduce
  1. dotnet graphql generate
  2. Open generated client code, check errors.
Relevant log output
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0234	The type or namespace name 'Helper' does not exist in the namespace 'StrawberryShake' (are you missing an assembly reference?)	Application	".."\Generated\GraphApiClient.Client.cs	1683	Active
Additional Context?

No response

Product

Strawberry Shake

Version

13.0.0-preview.93

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with dotnet graphql generate and inspect Generated\GraphApiClient.Client.cs, especially the reported line and its ComparisonHelper references. Trace the generator or template that emits the namespace, then verify that the generated client compiles and uses the existing StrawberryShake.Internal.ComparisonHelper namespace.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.