Potential issue reported by SAST tool
Open
- Dominant language
- Swift
- Stars
- 28k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
This code looks wrong (or at least does nothing :) )
https://github.com/danielgindi/Charts/blob/e91ba716190836b013ef8a9ca53e220ad5051e21/Source/Charts/Jobs/AnimatedViewPortJob.swift#L66
is it supposed to be
`_endTime = _endTime > **__startTime** ? _endTime : **__startTime**`
Contributor guide
Research direction
Open Source/Charts/Jobs/AnimatedViewPortJob.swift at line 66 and inspect the _endTime assignment in context. Determine whether the comparison should use _startTime as suggested, then verify the resulting animation behavior with the project's available checks. Done means the suspected no-op or incorrect assignment is resolved and the intended start and end times are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100