ChartsOrg / ChartsOrg/Charts

Remove Binary Search

Open
#3,640 3 comments 0 reactions 2 assignees Claimed by @liuxuan30 View on GitHub
bug
Dominant language
Swift
Stars
28k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

* [ x] I've read, understood, and done my best to follow the [*CONTRIBUTING guidelines](https://github.com/jjatie/Charts/blob/master/CONTRIBUTING.md).

## Background
Binary search provides optimized search for sorted collections. For unsorted collections, binary search is significantly slower than iterating over the collection. Charts implements binary search, however it does not enforce sorted collections, causing significantly slower lookup times for unsorted collections.

## Proposal
Remove binary search until such a time that we can a) enforce sorted chart data or b) have sorted and unsorted chart data with different look up algorithms.

## Charts Environment

**Charts version: 3.2
**Xcode version:10
**Swift version:4.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.