ChartsOrg / ChartsOrg/Charts

`ViewPortJob` `view` property

Open
#3,040 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
28k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

The `view` property on `ViewPortJob` is declared as being a `ChartViewBase`, but in it's subclasses method's implementations, it is frequently downcast to `BarLineChartViewBase`, sometimes forced downcast.

Are `ViewPortJob`s restricted to `BarLineChartViewBase` or should they be available to all chart types? Depending on the answer we need to change the type of `view` to `BarLineChartViewBase` or we need to not force downcast to `BarLineChartViewBase`.

Currently the only place `ViewPortJob`s are being used, is in `BarLineChartViewBase`. I'm not sure if this is a coincidence or a requirement.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.