ChartsOrg / ChartsOrg/Charts

Collection Conformance

Open
#2,999 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
28k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

`DataSets` are collections of `DataEntries`, and `ChartData` are collections of `DataSets`. Currently we have non-standard methods to access members of the collections (e.g. `entryForIndex`).

Due to the requirement of Objective-C compatibility, we are unable to do the proper thing and adopt `Collection` (and a few related protocols) in these classes. While we are able to implement specific functions to make them feel more "Swift-y", users will lose on out expected features that come for free with `Collection` conformance (such as `map`, `reduce`, `filter`).

Are there any thoughts with how to proceed in making collections feel more Swift like?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.