ChartMaker work wrong in a Combined Chart
- Dominant language
- Swift
- Stars
- 28k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/danielgindi/Charts/blob/e72f28061eea69f6dcb1b684b709946f50c87610/Source/Charts/Charts/ChartViewBase.swift#L611-L614
It seems that when using combined chart with marker, the code can't get data set from data by highlight dataset index. The CombinedChartView.data.dataset is an empty array, and the real data is in CombinedChartView.data.lineData.dataset or CombinedChartView.data.barData.dataset
Contributor guide
Research direction
Start at Source/Charts/Charts/ChartViewBase.swift lines 611-614 and trace how a highlight dataset index is resolved for a combined chart with a marker. Compare the top-level CombinedChartView.data.dataset with lineData.dataset and barData.dataset. Done means the marker can resolve the highlighted dataset from the combined chart's actual data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- data-visualization, mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100