Should valueFormatter property use weak modifier?
Open
★
discussion
- Dominant language
- Swift
- Stars
- 28k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Tihs property is found in `Charts-Swift.h` file, it's a delegate, should it use **weak** modifier to avoid retain cycle?
```
@property (nonatomic, strong) id _Nullable valueFormatter;
```
Contributor guide
Research direction
Start with the valueFormatter declaration in Charts-Swift.h and review the issue discussion about delegate ownership and retain cycles. Determine whether the property should use weak instead of strong, then verify the project still builds and related chart behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100