ChartsOrg / ChartsOrg/Charts

Removing weird `is...` getters?

Open
#1,752 12 comments 0 reactions 0 assignees View on GitHub
discussion
Dominant language
Swift
Stars
28k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

When first implementing this library, ObjC compatibility was in mind all the time.
And so, `is` getters were written too. The problem is, there was no feature like `getter=...` in Swift. (There's a relatively new option to use `@objc(is...)` on the getter, but that also requires declaring an additional private variable)

Now it seems that as Swift is getting more mature, there is not going to be such a feature.
Apple also tends to write Swift properties without the `is` prefix, unless there's only a getter.

I want to hear your thoughts, pros and cons, before making a decision on this.
Shoot.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.