ChainSafe / ChainSafe/zapi

CI does not run on stacked PRs (pull_request trigger restricted to main)

Open
#63 1 comment 0 reactions 0 assignees View on GitHub
Type: Maintenance
Dominant language
Zig
Stars
4
Forks
4
Avg merge
16h 14m
Merged PRs (30d)
2

Description

## Context

Noted while reviewing #56, which targets the `fix/napi-out-parameters-v2` branch (stacked on #57). No CI checks ran on it because `.github/workflows/ci.yml` triggers only on:

```yaml
on:
pull_request:
branches: [main]
```

Any PR whose base is another feature branch gets zero checks (build, zig tests, JS tests, lint), so stacked PRs can only be validated locally until the base PR merges or the PR is retargeted.

## Proposal

Drop the branch filter on the `pull_request` trigger (or widen it) so CI runs for PRs against any base branch:

```yaml
on:
pull_request:
push:
branches: [main]
```

Ref: `.github/workflows/ci.yml`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.