ChainSafe / ChainSafe/ssz

Rename the concept of `Block` to the `paddedBytes` for more clarity

Open
#468 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
61
Forks
26
Avg merge
3h 20m
Merged PRs (30d)
6

Description

**Is your feature request related to a problem? Please describe.**

Not a problem but more logical understanding of the code. During a PR review it's discussed that `Block` meant a different understanding in our domain. In our code base it's represents the chunks of 64 bytes used by the SHA256 for hashing.

**Describe the solution you'd like**

Would be really nice to rename this concept to `paddedBytes` which will be easy to understand.

**Additional context**

https://github.com/ChainSafe/ssz/pull/409#discussion_r1966019825

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the TypeScript repository for uses of `Block` and inspect the SHA256-related code where it represents 64-byte chunks. Rename the concept consistently to `paddedBytes`, update affected references and tests, and confirm the test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cryptography
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.