ChainSafe / ChainSafe/lodestar
Dedup caches in favor of ProposerPreferencesPool
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 483
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 156
Description
looks like we can just use the ProposerPreferencesPool in this PR instead of the pre-existing [SeenProposerPreferences](https://github.com/ChainSafe/lodestar/blob/38cd4b01e7582637a0e9bc444744de87ffa83a73/packages/beacon-node/src/chain/seenCache/seenProposerPreferences.ts#L7)
something to cleanup later
_Originally posted by @twoeths in https://github.com/ChainSafe/lodestar/pull/9377#pullrequestreview-4315410268_
Contributor guide
Research direction
Start with packages/beacon-node/src/chain/seenCache/seenProposerPreferences.ts and compare SeenProposerPreferences with ProposerPreferencesPool, including the implementation referenced by the linked pull request. Trace their callers to identify the duplicate cache, then confirm the obsolete cache is removed and existing tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100