ChainSafe / ChainSafe/lodestar

Investigate Goodbye response behavior

Open
#9,220 0 comments 0 reactions 0 assignees View on GitHub
meta-investigate
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 18h
Merged PRs (30d)
156

Description

> Sorry to comment on a closed issue, but this inconsistency still exists.
>
> We ran differential tests against all 6 CL clients on a fulu testnet and observed the following Goodbye response behavior:
>
> | Client | Response to incoming Goodbye |
> |------------|---------------------------------------------|
> | Lodestar | Responds with SUCCESS (echoes reason code) |
> | Teku | Stream reset (no response body) |
> | Prysm | Connection closed / EOF |
> | Lighthouse | No response |
> | Nimbus | No response |
> | Grandine | No response |
>
> Lodestar is the only client that responds to an incoming Goodbye. The other 5 clients process it internally (disconnect, apply backoff) but do not write back to the stream.

_Originally posted by @Alleysira in [#2635](https://github.com/ChainSafe/lodestar/issues/2635#issuecomment-4251039050)_

Contributor guide

Open the contributing guide

Research direction

No file or test is named. Start by locating the incoming Goodbye handling entry point in Lodestar's TypeScript consensus-client code, then compare its response behavior with the relevant protocol expectations and the six-client observations in the issue. Done means establishing whether Lodestar's SUCCESS response is correct and documenting the resulting behavior or required change.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.