ChainSafe / ChainSafe/lodestar

[fulu] performance issue deserializing DataColumnSidecar

Open
#8,623 0 comments 0 reactions 0 assignees View on GitHub
meta-bug spec-fulu :zebra:
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 16h
Merged PRs (30d)
150

Description

### Describe the bug

there is some significant time to deserialize gossipsub message, which happens multiple times per slot

in this example it's already >= 700ms

Image

my best guess is for gossip DataColumnSidecar message

update:

- confirm that it's DataColumnSidecar message that takes > 100ms to deserialize because I cannot find it in this old profile when hoodi was not forked

[v1.34.0_1k_main.cpuprofile.zip](https://github.com/user-attachments/files/23664594/v1.34.0_1k_main.cpuprofile.zip)

it's likely that this is due to memory allocation where NodeJS works with a lot of small Uint8Arrays

- it also happens in req/resp as well

Image

### Expected behavior

no performance issue
this is part of #8619

### Steps to reproduce

_No response_

### Additional context

_No response_

### Operating system

Linux

### Lodestar version or commit hash

v1.36.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.