ChainSafe / ChainSafe/lodestar

Integer overflow for withdrawals with more than 9M eth

Open
#7,892 0 comments 0 reactions 0 assignees View on GitHub
meta-bug
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 16h
Merged PRs (30d)
150

Description

### Describe the bug

Non critical bug to report, if you try to do a withdrawal with a balance over 2^53 - 1 ~9M then lodestar will break.

### Expected behavior

Don't break :D

### Steps to reproduce

kurtosis:
This works:
```yaml
participants:
- cl_type: lighthouse
- cl_type: lodestar
network_params:
withdrawal_type: "0x01"
validator_balance: 9000000
```
This doesn't work anymore:
```yaml
participants:
- cl_type: lighthouse
- cl_type: lodestar
network_params:
withdrawal_type: "0x01"
validator_balance: 9007300
```

### Additional context

_No response_

### Operating system

Linux

### Lodestar version or commit hash

latest

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.