ChainSafe / ChainSafe/lodestar

web3_provider tests depend on external source

Open
#7,250 3 comments 0 reactions 0 assignees View on GitHub
scope-testing
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 16h
Merged PRs (30d)
150

Description

The web3_provider tests in the prover package depend on a external source (our public sepolia node) to run correctly.
https://github.com/ChainSafe/lodestar/blob/b78cb92802cfc12c3a75f33a053055e3db5a7c45/packages/prover/test/unit/web3_provider.node.test.ts#L25

This behavior is not deterministic and we should not depend on external sources when running tests, especially unit tests.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.