ChainSafe / ChainSafe/lodestar

Remove fork designation and fork guard aliases

Open
#7,183 8 comments 1 reaction 0 assignees View on GitHub
scope-devex
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 16h
Merged PRs (30d)
150

Description

Remove fork designation and fork guard aliases

https://github.com/ChainSafe/lodestar/blob/734705659d0759f965935a36cf4854fc45d89697/packages/params/src/forkName.ts#L97-L101

---

Changes below have been implemented by https://github.com/ChainSafe/lodestar/pull/7441

Somehing we should consider for the 2.0 release is to rename pre / post fork types as current semantics are confusing and require feature awareness of each fork instead of just knowing about the fork name itself, and order of forks, which is simple since it's alphabetical.

e.g.

`ForkPreBlobs` --> `ForkPreDeneb`

`ForkBlobs` --> `ForkPostDeneb`

`isForkBlobs` --> `isForkPostDeneb`

etc.

see https://github.com/ChainSafe/lodestar/blob/unstable/packages/params/src/forkName.ts

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.