ChainSafe / ChainSafe/lodestar

Standardize fork param in the codebase

Open
#6,766 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 16h
Merged PRs (30d)
150

Description

a lot of our code has new "fork" param and it caused a lot of files changed, we can just get the config from state and determine the fork based on state.slot
the good thing is we don't have to keep computing fork in different functions if we pass fork param
I think we can store fork inside the CachedBeaconState so that we don't have to pass fork param around or keep recomputing it in different functions

_Originally posted by @twoeths in https://github.com/ChainSafe/lodestar/pull/6764#discussion_r1598985539_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.