ChainSafe / ChainSafe/lodestar

Prevent circular dependencies with eslint

Open
#3,929 3 comments 0 reactions 0 assignees View on GitHub
prio-low scope-devex
Dominant language
TypeScript
Stars
1.4k
Forks
483
Avg merge
1d 16h
Merged PRs (30d)
150

Description

**Motivation**

'import/no-cycle' is expensive computationally, consider restricting its `maxdepth`

See https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-cycle.md#maxdepth

A lint run in master currently takes `Done in 121.30s.` in Github Actions (from https://github.com/ChainSafe/lodestar/runs/5137987474?check_suite_focus=true#step:13:38)

In this PR for a failed run it took `in 137.5s` so the extra time is okay :+1:

**Description**

Prevent circular dependencies with eslint

See https://github.com/ChainSafe/lodestar/pull/3742 for an example implementation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.