ChainSafe / ChainSafe/gossamer

Implement `NetworkBlock.AnnounceBlock` on translation shim type.

Open
#4,804 0 comments 0 reactions 0 assignees View on GitHub
T-implementation
Dominant language
Go
Stars
454
Forks
144
PR merge metrics
No merged PRs in 30d

Description

## Issue summary

from design doc:
> AnnounceBlock method is used by GossipEngine to announce blocks before GRANDPA specific messages are sent. We already have functionality to create instances network.BlockAnnounceMessage using [core.createBlockAnnounce](https://github.com/ChainSafe/gossamer/blob/205b72beca190262c12bd13ccd38d12bd026d06f/dot/core/service.go#L230) that can be sent over the Network via Network.GossipMessage. We will need to replicate/make public the BlockAnnounceMessage constructor that also has the Network to send block announces.

## Implementation details

- Implement `NetworkBlock.AnnounceBlock` in translation shim typ utilizing existing `core` functionality.

## Other information and links

-

## Acceptance criteria

[] Calls to `AnnounceBlock` should gossip block announce to connected peers.
[] 70% unit test coverage on new `AnnounceBlock` functionality.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.