ChainSafe / ChainSafe/gossamer

Fix check validators signatures when applying forced changes

Open
#4,431 0 comments 0 reactions 1 assignee Claimed by @dimartiro View on GitHub
A-triage
Dominant language
Go
Stars
454
Forks
144
PR merge metrics
No merged PRs in 30d

Description

We did re introduce an old issue #3468 since the previous fix #4144 did brake the sync process when we have to apply forced justifications. So to prioritize the sync process we decided to re introduce the issue and address it here.

We have to be able to apply auth changes (scheduled or forced) before executing the block and verifying the justification.

I've been checking substrate code and they are:

1. [Applying the authorities changes](https://github.com/paritytech/polkadot-sdk/blob/da2dd9b7737cb7c0dc9dc3dc74b384c719ea3306/substrate/client/consensus/grandpa/src/import.rs#L578C7-L578C22)
2. [Importing the block](https://github.com/paritytech/polkadot-sdk/blob/da2dd9b7737cb7c0dc9dc3dc74b384c719ea3306/substrate/client/consensus/grandpa/src/import.rs#L582)
3. [Processing the justification](https://github.com/paritytech/polkadot-sdk/blob/da2dd9b7737cb7c0dc9dc3dc74b384c719ea3306/substrate/client/consensus/grandpa/src/import.rs#L650)

We want to reproduce that behavior on our side

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.