ChainSafe / ChainSafe/gossamer

chore(tests): Use `go:embed` for long result hex in runtime/exports_test.go

Open
#3,309 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
454
Forks
144
PR merge metrics
No merged PRs in 30d

Description

Certain tests use long result hex to test encoding/decoding of types. They are currently stored in a variable with linter disabled. These can get very long and we need to tidy it up.

I am unaware of all the tests. Here's one I could find: https://github.com/ChainSafe/gossamer/blob/development/dot/import_integration_test.go#L69

Searching for `//nolint:lll` could help find them.

_Originally posted by @timwu20 in https://github.com/ChainSafe/gossamer/pull/3297#discussion_r1224381231_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.