ChainSafe / ChainSafe/gossamer

chore: change the header field of `types.Block` to be a pointer `*Header`

Open
#2,813 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
454
Forks
144
PR merge metrics
No merged PRs in 30d

Description

The header type is quite big (184 bytes) so it should be passed around as a pointer, not a value, in the block type.

The alternative would be to handle `types.Block` as a pointer and change `NewBlock` to return a pointer to a block, but this might lead to more deltas and is less foolproof than the first approach which enforces the enhancement for block values and pointers to block.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.