ChainSafe / ChainSafe/gossamer

dot/sync: use `runtime.CheckInherents()` in block import process

Open
#1,873 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
454
Forks
144
PR merge metrics
No merged PRs in 30d

Description

## Task summary

- use the `runtime.CheckInherents()` function to validate the block inherents before importing a block
- may need clarity from spec team on when exactly this is needed, as substrate seems to sometimes not use it?

## Other information and links

https://github.com/paritytech/substrate/blob/4c3a55e7ca5c4c85c1eb53fd82ed71029d952510/primitives/inherents/src/lib.rs#L38

Contributor guide

Open the contributing guide

Research direction

Start at the block import path and the runtime.CheckInherents() API, then compare the linked Substrate inherents implementation. Confirm with the spec team when validation is required; done means inherents are checked before a block is imported according to the agreed rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.