ChainSafe / ChainSafe/forest

Allow overflow checks in CI on release builds

Open
#7,560 0 comments 0 reactions 1 assignee Claimed by @sudo-shashank View on GitHub
Type: Task
Dominant language
Rust
Stars
697
Forks
200
Avg merge
1d 5h
Merged PRs (30d)
65

Description

# Summary

https://github.com/ChainSafe/forest/pull/7559 removes the overflow checks from release builds that we ship to users; this is good from stability and perf POV. That said, it'd be great to still catch possible overflows in CI in case we're running checks on optimized build (sometimes needed).

# Completion Criteria

- [ ] Create new profile that inherits from release and allows overflow checks
- [ ] Use that profile in tests, e.g., local devnet, coverage, RPC calibnet... but make sure it doesn't ship to docker images or published release binaries.

# Additional Links & Resources

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.