ChainSafe / ChainSafe/forest

Migrate from `quick-protobuf` to `prost`

Open
#7,410 0 comments 0 reactions 0 assignees View on GitHub
Type: Task
Dominant language
Rust
Stars
697
Forks
200
Avg merge
1d 5h
Merged PRs (30d)
65

Description

# Summary

Follow https://github.com/libp2p/rust-libp2p/pull/6363 on migrating to `prost`. The unmaintained `quick-protobuf` dependency comes mostly from `rust-libp2p` (which should be dropped given the linked PR in the next release), but we also use it directly in Forest

https://github.com/ChainSafe/forest/blob/fc6578e96aaf19cfe5093e57e59212c2bcfb9fd3/src/libp2p_bitswap/bitswap_pb.rs#L15-L16

# Completion Criteria

- [ ] `quick-protobuf` is no longer a direct dependency of Forest
- [ ] Regression tests
- [ ] Make sure we don't re-rebuild the protobuf generated files on every check

# Additional Links & Resources

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.