ChainSafe / ChainSafe/forest

don't rely on drand networks for past beacons

Open
#4,838 2 comments 0 reactions 1 assignee Claimed by @EclesioMeloJunior View on GitHub
Type: Bug Type: Task
Dominant language
Rust
Stars
697
Forks
200
Avg merge
1d 5h
Merged PRs (30d)
65

Description

# Summary

An excellent summary is provided in https://github.com/filecoin-project/lotus/issues/12527#issuecomment-2388289290

tl;dr we shouldn't rely on drand providing endpoints for historical beacons. It's both not scalable, incorrect in certain epochs and not reliable.

The downside of this is reduced performance when requesting beacon entries for really old epochs, e.g., first epoch of calibnet.

# Completion Criteria

- [ ] Identify places where we call the drand servers for beacon data - if the data is available on chain, we should not do this and get that tipset's drand entry. There is at least one - https://github.com/ChainSafe/forest/blob/5fd1ec506ee7db4d83fa8aca14338429bf11938c/src/rpc/methods/state.rs#L1725-L1758
- [ ] assert that performance is similar to Lotus's, both calibnet and mainnet.

# Additional Links & Resources

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.